[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to Collapse All Trees in Outline View #74026

Merged

Conversation

Daniel-McCarthy
Copy link
Contributor

Fixes #70369.


Summary:
It has been suggested to add a keybind for collapsing all trees in the Outline View. A command has been created to handle collapsing the trees and has been registered so that a user may assign their own keyboard shortcut to it via Preferences.


Demonstrates all the tree nodes of the Outline view being collapsed via keyboard shortcut.

This adds a command handler that attempts to find and call the collapse action for the outline view.
Takes the command made to collapse all elements fo the Outline View and registers it so that users can bind a keyboard shortcut to the command.
@jrieken
Copy link
Member
jrieken commented May 21, 2019

I would argue this should be done so that it's the same for all trees, e.g have the same for the explorer etc... /cc @joaomoreno

…ersion

This implementation is specific to the outlinePanel. Ideally we want one implementation that handels all list views. Therefore this implementation is being removed.
This adds the ability to perform a collapse all on a full tree upon a keyboard shortcut. Upon performing the shortcut, it will collapse every node on the tree.
@msftclas
Copy link
msftclas commented May 22, 2019

CLA assistant check
All CLA requirements met.

@jrieken jrieken requested a review from bpasero May 22, 2019 15:34
@joaomoreno joaomoreno self-requested a review May 23, 2019 09:24
Copy link
Member
@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! 🍻

@joaomoreno joaomoreno added this to the May 2019 milestone May 23, 2019
@joaomoreno joaomoreno added list-widget List widget issues ux User experience issues labels May 23, 2019
@joaomoreno joaomoreno merged commit 11f4127 into microsoft:master May 23, 2019
@bpasero bpasero removed their request for review May 23, 2019 09:51
@Daniel-McCarthy Daniel-McCarthy deleted the Shortcut-Collapse-All-Outline-View branch May 25, 2019 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
list-widget List widget issues ux User experience issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortcut to collapse all in outline view
4 participants