-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shortcut to Collapse All Trees in Outline View #74026
Merged
joaomoreno
merged 4 commits into
microsoft:master
from
Daniel-McCarthy:Shortcut-Collapse-All-Outline-View
May 23, 2019
Merged
Add shortcut to Collapse All Trees in Outline View #74026
joaomoreno
merged 4 commits into
microsoft:master
from
Daniel-McCarthy:Shortcut-Collapse-All-Outline-View
May 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command handler that attempts to find and call the collapse action for the outline view.
Takes the command made to collapse all elements fo the Outline View and registers it so that users can bind a keyboard shortcut to the command.
jrieken
requested changes
May 21, 2019
I would argue this should be done so that it's the same for all trees, e.g have the same for the explorer etc... /cc @joaomoreno |
…ersion This implementation is specific to the outlinePanel. Ideally we want one implementation that handels all list views. Therefore this implementation is being removed.
This adds the ability to perform a collapse all on a full tree upon a keyboard shortcut. Upon performing the shortcut, it will collapse every node on the tree.
joaomoreno
approved these changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! 🍻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70369.
Summary:
It has been suggested to add a keybind for collapsing all trees in the Outline View. A command has been created to handle collapsing the trees and has been registered so that a user may assign their own keyboard shortcut to it via Preferences.