-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git: Checkout to a tracked local branch instead when trying to checkout to a remote branch #61149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laphets
changed the title
Git: Checkout to a tracking local branch instead of an upstream branch
Git: Checkout to a tracking local branch instead of a remote branch
Oct 17, 2018
laphets
changed the title
Git: Checkout to a tracking local branch instead of a remote branch
Git: Checkout to a tracking local branch instead when try to checkout a remote branch
Oct 17, 2018
laphets
changed the title
Git: Checkout to a tracking local branch instead when try to checkout a remote branch
Git: Checkout to a tracking local branch when trying to checkout to a remote branch
Oct 17, 2018
laphets
changed the title
Git: Checkout to a tracking local branch when trying to checkout to a remote branch
Git: Checkout to a tracked local branch instead when trying to checkout to a remote branch
Oct 17, 2018
WenInCode
reviewed
Oct 18, 2018
Update extensions/git/src/api/git.d.ts Fix another typo Fix some typo
laphets
force-pushed
the
fix-branch-checkout
branch
from
October 18, 2018 02:57
852c8be
to
d24031b
Compare
@joaomoreno Could you help me check this, thx.. |
@joaomoreno this is vital |
Thanks! 🎆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60904
Description
Problem raised when trying to checkout a remote branch, while there existing a local branch having the same name.
Solution
Basically, we can check whether the remote branch name matches with any local branch. However, I think it's confusing sometimes when the local branch is tracking to an upstream branch with another name. Therefore, I think it's better to judge by the tracking ship instead of simply branch name.
By using
we can get all the tracking relations from local branch to the upstream branch, just as what is shown in the capture below.
Therefore, I add a
GetTracking
method inextensions/git/src/git.ts
to parse for the tracking relationship and return. And when a user is trying, for instance, checkout toorigin/master
, vscode will find the tracking relation frommaster
toorigin/master
, and checkout tomaster
instead.