[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Explore decorations in xterm.js #140308

Closed
Tyriar opened this issue Jan 7, 2022 · 3 comments · Fixed by #142538
Closed

Shell integration: Explore decorations in xterm.js #140308

Tyriar opened this issue Jan 7, 2022 · 3 comments · Fixed by #142538
Assignees
@meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
February 2022

Comments

@Tyriar
Copy link
Member
Tyriar commented Jan 7, 2022 •
edited
Loading

This would let us show decorations in the buffer, now that we understand more about it xtermjs/xterm.js#1852
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jan 7, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 7, 2022
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming and removed feature-request Request for new features or functionality labels Jan 7, 2022
@Tyriar Tyriar modified the milestones: January 2022, February 2022 Jan 26, 2022
@Tyriar Tyriar removed their assignment Jan 26, 2022
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
@meganrogge meganrogge mentioned this issue Feb 8, 2022
Merged
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
@meganrogge @mustard-mh
xterm@4.18.0-beta.4
c0a1363 
Adds decoration API, fixes  microsoft#140308
@meganrogge meganrogge mentioned this issue Feb 19, 2022
Closed
3 tasks
@pitust
Copy link
pitust commented Feb 23, 2022 •
edited
Loading

Can i say i hate this feature? I really do, it covers up the prompt and doesn't add anything of value (i can select things myself, thank you very much)

Also how on earth do you turn it off?

@Tyriar
Copy link
Member Author
Tyriar commented Feb 23, 2022

@pitust shell integration is off by default, but if you have that turned on the decorations will appear. It shouldn't be covering up the prompt, that would be a bug. It's been under heavy development the last 2 weeks and has been in a not so great state because of that.

You can turn off the decorations currently by setting this:

  "terminal.integrated.shellIntegration.commandIconDefault": "",
  "terminal.integrated.shellIntegration.commandIconError": "",
  "terminal.integrated.shellIntegration.commandIcon": "",

This will likely change though as that's not that easy to figure out.

@Tyriar
Copy link
Member Author
Tyriar commented Feb 23, 2022

Created #143737 to follow this up

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@meganrogge
xterm@4.18.0-beta.4
8690334 
Adds decoration API, fixes  microsoft#140308
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

Add terminal shell integration decorations microsoft/vscode
4 participants
@Tyriar @meganrogge @pitust and others