This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Update to latest vscode-languageclient #3064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f15c23. This effectively brings in the commit 3b02de0 back again. Originally reverted because it requires vscode 1.41.x, which was just released at the time of Go extension 0.13.0 release. Currently 1.42.x is the latest version, and we expect another cycle of vscode release when the next version of Go extension is out. We 8000 need more up-to-date version of vscode-languageclient to bring in various fixes to problems such as microsoft/vscode-languageserver-node#442 Considered only minor version upgrade but I couldn't find a suitable newer version than 5.2.1 (https://www.npmjs.com/package/vscode-languageclient)
|
I think you will need to increase the value of the VS Code engine here to |
|
The latest version of the language client seems to need 1.42 where as the previous version needed only 1.41 Am ok changing our min supported version of VS Code to 1.41, but am hesitant to change it to 1.42 without giving some time for users to upgrade. 7d0069a reflects the change to do the above. Side note: microsoft/vscode-languageserver-node@f5542d9#r37530736 |
|
Closing this PR for now |
|
The latest beta version 0.14.0-beta.1 is using version 6.1.0 of the language client. Please use this to test out the fixes from the language client |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f15c23.
This effectively brings in the commit 3b02de0 back again.
Originally reverted because it requires vscode 1.41.x,
which was just released at the time of Go extension 0.13.0
release. Currently 1.42.x is the latest version, and we expect
another cycle of vscode release when the next version of Go
extension is out.
We need more up-to-date version of vscode-languageclient to
bring in various fixes to problems such as
microsoft/vscode-languageserver-node#442
Considered only minor version upgrade but I couldn't find a suitable
newer version than 5.2.1
(https://www.npmjs.com/package/vscode-languageclient)