-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Seanmcm/0 20 1 release #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seanmcm/0 20 1 release #2749
Conversation
Updated external console option to show changes to support for integratedTerminal.
Update changelog, fwlinks, and update telemetry API
launch.md
Outdated
@@ -22,7 +22,9 @@ Set or change the following options to control VS Code's behavior during debuggi | |||
Tells _GDB or LLDB_ what paths to search for .so files. Separate multiple paths with a semicolon. Example: `"/Users/user/dir1;/Users/user/dir2"`. | |||
|
|||
* #### `externalConsole` | |||
If set to `true`, launches an external console for the application. If `false`, no console is launched and VS Code's debugging console is used. Note this option is ignored in some cases for technical reasons. | |||
Windows: When set to true, it will spawn an external console. When set to false, it will use VS Code's integratedTerminal. | |||
Linux: When set to true, it will notify VS Code to spawn an external console. When set to false, it will use VS Code's integratedTerminal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is missing a period. I fixed it in #2750, along with other minor issues.
@@ -1411,14 +1411,14 @@ | |||
"vscode-cpptools": "2.1.1", | |||
"vscode-debugadapter": "~1.24.0", | |||
"vscode-debugprotocol": "~1.24.0", | |||
"vscode-extension-telemetry": "~0.1.0", | |||
"vscode-extension-telemetry": "~0.0.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to roll this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they regressed our telemetry -- they recommended we roll back until it's fixed.
@@ -4,7 +4,7 @@ | |||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you remove the colon? I Don't know what this diff means>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there's no colon removed. Are you seeing a change on that line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the colon is marked as "red" I don't know why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's just some GitHub visualization bug -- it's red in the pre-post versions. The raw data doesn't have that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's red because the comments as messing up the formatter since comments are not valid in JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense -- VS Code uses a json parser for tasks.json that allows comments though, so it's just a GitHub issue.
No description provided.