8000 Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. by Colengms · Pull Request #13374 · microsoft/vscode-cpptools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. #13374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 22, 2025
Merged

Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. #13374

merged 20 commits into from
Mar 22, 2025

Conversation

Colengms
Copy link
Contributor
@Colengms Colengms commented Mar 14, 2025 •
edited
Loading

Add 3 config fields (+ settings) related to recursive includes

  • recursiveIncludes.reduce - Allows the existing 'reducing' of recursive includes to be avoided, if set to never. There is a default value which we intended to use to support an optimization in a future where a TU can be started up without reducing only if tag parsing is not already done.

  • recursiveInclues.priority - Allows recursive includes to be searched either beforeSystemIncludes or afterSystemIncludes.

  • recursiveIncludes.order - Allows the search order within a recursive include to be depthFirst or breadthFirst.

The reduce setting addresses: #11780

@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Mar 14, 2025
bobbrow
bobbrow reviewed Mar 14, 2025
View reviewed changes
bobbrow
bobbrow reviewed Mar 14, 2025
View reviewed changes
@Colengms Colengms changed the title Add settings for 'reduce' and 'priorty' of recursive includes. Add settings for 'reduce', 'priorty' and internal order of recursive includes. Mar 15, 2025
@Colengms Colengms changed the title Add settings for 'reduce', 'priorty' and internal order of recursive includes. Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. Mar 15, 2025
bobbrow
bobbrow reviewed Mar 17, 2025
View reviewed changes
bobbrow
bobbrow reviewed Mar 17, 2025
View reviewed changes
bobbrow
bobbrow reviewed Mar 17, 2025
View reviewed changes
@Colengms Colengms changed the title Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. Add settings for 'requireHeaders', 'reduce', 'priority' and internal 'order' of recursive includes. Mar 17, 2025
@Colengms Colengms changed the title Add settings for 'requireHeaders', 'reduce', 'priority' and internal 'order' of recursive includes. Add settings for 'reduce', 'priority' and internal 'order' of recursive includes. Mar 18, 2025
@Colengms Colengms marked this pull request as ready for review March 18, 2025 21:47
@Colengms Colengms requested a review from a team as a code owner March 18, 2025 21:47
sean-mcmanus
sean-mcmanus requested changes Mar 20, 2025
View reviewed changes
@Colengms Colengms merged commit 225143f into main Mar 22, 2025
6 checks passed
@Colengms Colengms deleted the coleng/recursive_includes_settings branch March 22, 2025 01:19
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Mar 22, 2025
@Colengms Colengms mentioned this pull request Apr 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbrow bobbrow bobbrow left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
cpptools
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Colengms @bobbrow @sean-mcmanus
0