update node version, @vsce/vsce, and fix build errors from node updat… #4055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarni
approved these changes
Sep 10, 2024
qarni
reviewed
Sep 10, 2024
|
NOTE: I performed a super fast smoke test to make sure things were behaving as expected, and they are. |
gcampbell-msft
added a commit
that referenced
this pull request
Sep 17, 2024
#4055) * update node version, @vsce/vsce, and fix build errors from node update, add improved signing * update node in ci builds * update vscode engine * fix copy * don't sign vsix with VsixSha2 anymore * update changelog
gcampbell-msft
added a commit
that referenced
this pull request
Sep 17, 2024
* update node version, @vsce/vsce, and fix build errors from node updat… (#4055) * update node version, @vsce/vsce, and fix build errors from node update, add improved signing * update node in ci builds * update vscode engine * fix copy * don't sign vsix with VsixSha2 anymore * update changelog * xml2js cg (#4069) * xml2js cg * update tests as well * try update partial * switch kit? * ninja is added to path so it should work, still investigating * update action version with same tool versions * changes to test * test output * more testing * test macos-13 * remove logging * remove logging * try explicit macos-14 * go back to macos-13 * remove static version of vscode * need to use 13 * comment * update node (#4072) * ensure ready to release (#4074) * ensure ready to release * update third party * update workflows (#4076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our signing so that we support the new signing support partially documented here: https://gist.github.com/dtivel/c0b722fe1756c2b614d7096bde602c66.
To complete this, it required updating our signing as well as our node version and vsce version, and the resulting changes required for building.
NOTE: I've locally verified that the new signing process worked.