8000 [highfive] update to 3.0.0 by miyanyan · Pull Request #46268 · microsoft/vcpkg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[highfive] update to 3.0.0 #46268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 5, 2025
Merged

[highfive] update to 3.0.0 #46268

merged 5 commits into from
Jul 5, 2025

Conversation

miyanyan
Copy link
Contributor
@miyanyan miyanyan commented Jul 3, 2025
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

refer to https://github.com/highfive-devs/highfive/blob/main/CMakeLists.txt#L65-L71
these options maybe need to be added as a feature, exclude HIGHFIVE_UNIT_TESTS?

option(HIGHFIVE_TEST_SPAN "Enable testing std::span, requires C++20" ${HIGHFIVE_TEST_SPAN_DEFAULT})
option(HIGHFIVE_TEST_BOOST "Enable testing Boost features" OFF)
option(HIGHFIVE_TEST_BOOST_SPAN "Additionally, enable testing `boost::span`" OFF)
option(HIGHFIVE_TEST_EIGEN "Enable testing Eigen" OFF)
option(HIGHFIVE_TEST_OPENCV "Enable testing OpenCV" OFF)
option(HIGHFIVE_TEST_XTENSOR "Enable testing xtensor" OFF)
option(HIGHFIVE_TEST_HALF_FLOAT "Enable testing half-precision floats" OFF)

so I removed the feature tests, add feature opencv, the HIGHFIVE_TEST_BOOST_SPAN HIGHFIVE_TEST_SPAN HIGHFIVE_TEST_HALF_FLOAT don't require external libraries

also removed patch fix-error-C1128.patch that was added in #21897, I didn't get this error, please let me know if this is not right

@miyanyan
Copy link
Contributor Author
miyanyan commented Jul 3, 2025

seems the arm64_windows ci failure is caused by opencv
install-arm64-windows-dbg-out.log

issue_body.md

vicroms
vicroms requested changes Jul 4, 2025
View reviewed changes
Copy link
Member
@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's unexpected passes on the feature tests please update ci.feature.baseline.txt.

D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:954:1: error: highfive[core]:arm64-windows passed but was marked expected to be a cascaded failure
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:954:1: error: highfive[core,eigen3]:arm64-windows passed but was marked expected to be a cascaded failure
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:954:1: error: highfive[core,xtensor]:arm64-windows passed but was marked expected to be a cascaded failure
D:\a\_work\1\s\scripts\azure-pipelines/../ci.feature.baseline.txt:954:1: error: highfive[core,boost]:arm64-windows passed but was marked expected to be a cascaded failure

@vicroms vicroms marked this pull request as draft July 4, 2025 09:19
@vicroms vicroms self-assigned this Jul 4, 2025
@vicroms vicroms added info:reviewed Pull Request changes follow basic guidelines category:port-update The issue is with a library, which is requesting update new revision labels Jul 4, 2025
@miyanyan miyanyan marked this pull request as ready for review July 5, 2025 03:06
@vicroms vicroms merged commit e2358cb into microsoft:master Jul 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

Assignees

@vicroms vicroms

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyanyan @vicroms
0