-
Notifications
You must be signed in to change notification settings - Fork 48
Add Legendre 2001 ctation #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the comments.
|
||
Let us now compare the estimated Shannon and Faith indices across | ||
samples. First we add Shannon and Faith indices. | ||
Load `picante` R package and get the `phylo` stored in `rowTree`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intention of this? It seems that picante package is not loaded even though it says like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. It's not something I have changed. That's a previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason it shows as part of this commit.
Have you synced your branch with the latest version?
Anyway I thing that line could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now figure out how to sync branches. It says "up to date".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you use normal git merge when updating with devel branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used to. Now I usually use git rebase
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will now just create new branches from devel and merge those directly on this repo. I think it's be easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase might explain this behavior
Co-authored-by: Leo Lahti <leo.lahti@iki.fi>
Closed in favor of #485. |
I added this citation.
For some reason, I have four commit but in reality only one file is changed.