8000 Add Legendre 2001 ctation by artur-sannikov · Pull Request #458 · microbiome/OMA · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Legendre 2001 ctation #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

artur-sannikov
Copy link
Contributor

I added this citation.

For some reason, I have four commit but in reality only one file is changed.

Copy link
Member
@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the comments.

artur-sannikov added a commit to artur-sannikov/OMA that referenced this pull request Apr 29, 2024

Let us now compare the estimated Shannon and Faith indices across
samples. First we add Shannon and Faith indices.
Load `picante` R package and get the `phylo` stored in `rowTree`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intention of this? It seems that picante package is not loaded even though it says like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. It's not something I have changed. That's a previous commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason it shows as part of this commit.

Have you synced your branch with the latest version?

Anyway I thing that line could be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now figure out how to sync branches. It says "up to date".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use normal git merge when updating with devel branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to. Now I usually use git rebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will now just create new branches from devel and merge those directly on this repo. I think it's be easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase might explain this behavior

artur-sannikov added a commit that referenced this pull request Apr 30, 2024
artur-sannikov added a commit that referenced this pull request May 2, 2024
@artur-sannikov
Copy link
Contributor Author

Closed in favor of #485.

artur-sannikov added a commit that referenced this pull request May 17, 2024
artur-sannikov added a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0