8000 242 & 248 fix widget bugs by Orta21 · Pull Request #36 · metriport/metriport · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

242 & 248 fix widget bugs #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 7, 2023
Merged

242 & 248 fix widget bugs #36

merged 4 commits into from
Jan 7, 2023

Conversation

Orta21
Copy link
Member
@Orta21 Orta21 commented Jan 7, 2023

Ticket: 242 & 248

Description

Update the widget bugs

Release Plan

Asap

@Orta21
Copy link
Member Author
Orta21 commented Jan 7, 2023

Recording of changes

Screen.Recording.2023-01-07.at.11.17.42.AM.mov

Goncharo
Goncharo requested changes Jan 7, 2023
View reviewed changes
Copy link
Member
@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, couple of logic comments, also I think the apple.png was an accidental addition

@Orta21
Copy link
Member Author
Orta21 commented Jan 7, 2023

Fixing merge conflict

Goncharo
Goncharo approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member
@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢 🚢 🚢

@Orta21 Orta21 merged commit 1e95115 into develop Jan 7, 2023
@Orta21 Orta21 deleted the widget_updates branch January 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

Assignees

@Goncharo Goncharo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orta21 @Goncharo
0