Parameterize URLs in API, update config, remove not needed standalone… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orta21
approved these changes
Dec 23, 2022
leite08
approved these changes
Dec 24, 2022
README.md
Outdated
| ### **Environment Setup** | ||
|
|
||
| First, you'll need to create and configure a deployment config file: `/infra/config/standalone.ts`. You can see `example.ts` in the same directory for a sample of what the end result should look like. Then, proceed with the deployment steps below. | ||
| 1. You'll need to create and configure a deployment config file: `/infra/config/prod.ts`. You can see `example.ts` in the same directory for a sample of what the end result should look like. Optionally, you can setup consig files for `staging` and `sandbox` deployments. Then, proceed with the deployment steps below. |
There was a problem hiding this comment.
Typo (consig > config) + suggestion for this:
Optionally, you can setup consig files for
stagingandsandboxdeployments.
Optionally, you can setup config files for stagingandsandbox deployments, based on your environment needs.
Comment on lines
+24
to
+25
| static getConnectWidgetUrl(): string { | ||
| return getEnvVarOrFail("CONNECT_WIDGET_URL"); |
| @@ -2,14 +2,21 @@ import { getApiToken } from "./api"; | |||
| import { NavigateFunction } from "react-router-dom"; | |||
| import Constants from "./constants"; | |||
|
|
|||
| function buildEnvParam(envParam: string) { | |||
| return `&${envParam}=true`; | |||
There was a problem hiding this comment.
maybe leave & out of this function? this way, if needed, we can position the result of this as the first param
| @@ -32,5 +32,6 @@ export interface EnvConfig { | |||
| host: string; | |||
| domain: string; | |||
| }; | |||
| connectWidgetUrl?: string; | |||
There was a problem hiding this comment.
Could do some tweaking on the type definition so one of these is present: connectWidget or connectWidgetUrl
added 2 commits
December 23, 2022 17:17
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… env #55