8000 First cut changes in preparation for environment upgrade by gavinevans · Pull Request #2124 · metoppv/improver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

First cut changes in preparation for environment upgrade #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: mobt_800_env_upgrade_feature_branch
Choose a base branch
from
Open

First cut changes in preparation for environment upgrade #2124

wants to merge 15 commits into from

Conversation

gavinevans
Copy link
Contributor

Part of https://github.com/metoppv/mo-strategic-issues/issues/150

Description
This PR provides an initial set of changes to reduce the errors and failures when upgrading the package versions used by the improver repo. Please note that this is targeting a feature branch, rather than master. I've also unpinned the environments used by GitHub Actions.

The issues addressed in this PR:

  • Iris now strictly only allows cubes within a cubelist, whereas previously you could put a cubelist in a cubelist. I've corrected some instances of this behaviour.
  • np.product => np.prod
  • np.int => np.int32
  • np.NAN => np.nan
  • np.NaN => np.nan
  • assertRaisesRegexp => assertRaisesRegex
  • Cube(None) => Cube(shape=(0,))

There are a large number of other errors that will be addressed by forthcoming PRs.

Feature branch tests:

922 failed, 5633 passed, 140 skipped, 1 xpassed, 3827 warnings, 493 errors in 131.53s (0:02:11)

i.e. a ~20% failure rate.

Following this PR:

805 failed, 6120 passed, 228 skipped, 1 xpassed, 3900 warnings, 11 errors in 124.60s (0:02:04)

i.e. a ~12% failure rate.

Testing:

  • Ran tests and they passed OK

mspelman07
mspelman07 requested changes May 20, 2025
View reviewed changes
Copy link
Contributor
@mspelman07 mspelman07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly I think this looks good, I just have a couple of minor comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspelman07 mspelman07 mspelman07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinevans @mspelman07
0