Make is_iterable changes applicable to percentiles option #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable retention of scalar coordinates that are produced during percentile generation from coordinate collapse. This change also ensures that any scalar time coordinates that are created in this way adhere to the improver metadata standards. * style fixes.
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## is_iterable #2090 +/- ##
==============================================
Coverage ? 98.39%
==============================================
Files ? 134
Lines ? 13265
Branches ? 0
==============================================
Hits ? 13052
Misses ? 213
Partials ? 0 ☔ View full report in Codecov by Sentry. |
cpelley
pushed a commit
that referenced
this pull request
Jan 30, 2025
* MOBT-797: Coordinate retention in percentile generation (#2087) * Enable retention of scalar coordinates that are produced during percentile generation from coordinate collapse. This change also ensures that any scalar time coordinates that are created in this way adhere to the improver metadata standards. * style fixes. * Setting percentiles with as_iterable --------- Co-authored-by: bayliffe <benjamin.ayliffe@metoffice.gov.uk>
MoseleyS
added a commit
that referenced
this pull request
Feb 3, 2025
…ad_time using it (#2088) * radius_by_lead_time improved input handling * Make is_iterable changes applicable to percentiles option (#2090) * MOBT-797: Coordinate retention in percentile generation (#2087) * Enable retention of scalar coordinates that are produced during percentile generation from coordinate collapse. This change also ensures that any scalar time coordinates that are created in this way adhere to the improver metadata standards. * style fixes. * Setting percentiles with as_iterable --------- Co-authored-by: bayliffe <benjamin.ayliffe@metoffice.gov.uk> * TEDST: is_iterable * Update improver/nbhood/__init__.py Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk> * Update __init__.py * Update nbhood.py --------- Co-authored-by: Phil <phil.relton@metoffice.gov.uk> Co-authored-by: bayliffe <benjamin.ayliffe@metoffice.gov.uk> Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adaption to the is_iterable branch allows the percentiles attribute of
MetaNeighbourhoodto be set by a single value in a similar way to this adaption.