Avoid cell method duplication in ApplyEMOS #2095
Conversation
…if probability forecasts are input with an existing cell method e.g. to describe a period diagnostic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 124 134 +10
Lines 12212 13267 +1055
==========================================
+ Hits 12016 13056 +1040
- Misses 196 211 +15 ☔ View full report in Codecov by Sentry. |
cea6788 to
1fde8ed
Compare
There was a problem hiding this comment.
We could be more selective with the cell_method removal here rather than re-adding cell methods after purging them all, but perhaps the ensemble mean related cell method can vary, which makes removing it more complex.
Either way, this does the job. Thanks Gavin.
|
We can talk about this in a stand-up, but I was wondering whether another possible solution to the duplicate cell method problem would be to modify the This has the benefit of being more comprehensive than adding individual duplicate handling in different plugins, but might be excessive as it would add additional processing to all plugins which inherit from the class, even if they don't add/modify cell methods. |
There was a problem hiding this comment.
After discussion, we've decided that attempting to fix all issues related to duplicate cell methods in the source plugin, as well as a catch-all fix in the save method, is sufficient as a solution for now.
I'm happy that this PR fixes the duplicate cell method issue in this plugin.
Addresses #https://github.com/metoppv/mo-blue-team/issues/844
This PR removes the potential for cell methods to be duplicated within the ApplyEMOS plugin, when, for example, a probability forecast describing a period is provided.
Testing: