8000 Adds CLI for gradient-between-adjacent-grid-squares by MoseleyS · Pull Request #2037 · metoppv/improver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds CLI for gradient-between-adjacent-grid-squares #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 23, 2024
Merged

Adds CLI for gradient-between-adjacent-grid-squares #2037

merged 11 commits into from
Oct 23, 2024

Conversation

MoseleyS
Copy link
Contributor
@MoseleyS MoseleyS commented Oct 4, 2024

Addresses https://metoffice.atlassian.net/browse/EPPT-1162

Adds a CLI for the GradientBetweenAdjacentGridSquares plugin. While setting up tests for this, I found it needed to handle "status_flag" AuxCoords too, so I have added this.

Acceptance test data: metoppv/improver_test_data#56

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@MoseleyS MoseleyS self-assigned this Oct 4, 2024
@MoseleyS MoseleyS mentioned this pull request Oct 4, 2024
Merged
@codecov Codecov
Copy link
codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (84a8944) to head (5051022).
Report is 32 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   98.39%   98.36%   -0.03%     
==========================================
  Files         124      133       +9     
  Lines       12212    12880     +668     
==========================================
+ Hits        12016    12670     +654     
- Misses        196      210      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mspelman07
mspelman07 requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor
@mspelman07 mspelman07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly does what we need but a few tweaks for you.

@mspelman07 mspelman07 added the EPP PR's related to Enhancing Post Processing team label Oct 9, 2024
mspelman07
mspelman07 reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor
@mspelman07 mspelman07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing but otherwise I'm happy

@MoseleyS
Corrects indentation in doc string
f10bab1
@MoseleyS
Merge branch 'refs/heads/master' into cli_gradient
5051022 
* refs/heads/master:
  Failing CI (metoppv#2040)
  Gradient between vertical levels (metoppv#2030)
  Categorical fix for Deterministic data (metoppv#2038)

# Conflicts:
#	improver_tests/acceptance/SHA256SUMS
@mspelman07 mspelman07 merged commit dfd7119 into metoppv:master Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshukolusu16 seshukolusu16 seshukolusu16 approved these changes

@mspelman07 mspelman07 mspelman07 approved these changes

Assignees

@MoseleyS MoseleyS

Labels
EPP PR's related to Enhancing Post Processing team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoseleyS @seshukolusu16 @mspelman07
0