8000 Plugin and tests to extract values from a table by mspelman07 · Pull Request #2019 · metoppv/improver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Plugin and tests to extract values from a table #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 13, 2024
Merged

Plugin and tests to extract values from a table #2019

merged 11 commits into from
Sep 13, 2024

Conversation

mspelman07
Copy link
Contributor
@mspelman07 mspelman07 commented Jul 24, 2024 •
edited
Loading

Addresses https://metoffice.atlassian.net/browse/EPPT-1304
Acceptance_test_data PR: metoppv/improver_test_data#52

Adds in the plugin, CLI and tests to extract values from a table based on provided row and column cubes

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@mspelman07 mspelman07 added the EPP PR's related to Enhancing Post Processing team label Jul 24, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (84a8944) to head (21b696d).
Report is 26 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
- Coverage   98.39%   98.28%   -0.12%     
==========================================
  Files         124      132       +8     
  Lines       12212    12814     +602     
==========================================
+ Hits        12016    12594     +578     
- Misses        196      220      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mspelman07 mspelman07 mentioned this pull request Jul 24, 2024
Merged
MoseleyS
MoseleyS requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor
@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things that I think need straightening out. The only important one is setting the output units.

@bayliffe bayliffe self-assigned this Aug 21, 2024
bayliffe
bayliffe requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor
@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lovely feedback for you.

@bayliffe bayliffe assigned mspelman07 and unassigned bayliffe Aug 21, 2024
@mspelman07 mspelman07 assigned bayliffe and unassigned mspelman07 Aug 22, 2024
bayliffe
bayliffe reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor
@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further waffle from me.

@bayliffe bayliffe assigned mspelman07 and unassigned bayliffe Aug 22, 2024
@mspelman07 mspelman07 assigned bayliffe and unassigned mspelman07 Sep 2, 2024
bayliffe
bayliffe previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor
@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy. I've left one question on the acceptance test data PR.

@bayliffe bayliffe assigned mspelman07 and unassigned bayliffe Sep 3, 2024
MoseleyS
MoseleyS requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor
@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but there's one small suggestion you could incorporate if you want to.

Marked as request changes because of the request to changes to the acceptance test data PR.

@mspelman07 mspelman07 assigned bayliffe and unassigned mspelman07 Sep 6, 2024
@bayliffe bayliffe assigned MoseleyS and mspelman07 and unassigned bayliffe Sep 9, 2024
MoseleyS
MoseleyS approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor
@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, acceptance test data looks ok. Queries resolved.

@MoseleyS MoseleyS merged commit 03f3f29 into metoppv:master Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoseleyS MoseleyS MoseleyS approved these changes

@bayliffe bayliffe bayliffe approved these changes

Assignees

@MoseleyS MoseleyS

@mspelman07 mspelman07

Labels
EPP PR's related to Enhancing Post Processing team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mspelman07 @MoseleyS @bayliffe
0