Remove old threshold tests and retain only the pytest versions #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinevans
approved these changes
May 9, 2024
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for threshold were rewritten in PR #1913. As this comment indicates the intention was to remove the old tests once the review process was complete; they were left in place to give confidence during the review that all of the memory efficiency changes had no impact on the outputs. However, we merged the PR without deleting the old tests and renaming the new ones. This PR rectifies this mistake.
Unfortunately the git diff below makes this look horrific as I have removed
test_Threshold.pyand renamedtest_ThresholdPytest.pytotest_Threshold.py, so it is trying to diff as if one has become the other. This PR is just a deletion and a rename of the existing test files.Testing: