SnowSplitter output cube names are now the same as their StaGE couterparts #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
==========================================
+ Coverage 97.15% 98.40% +1.24%
==========================================
Files 124 124
Lines 12065 12069 +4
==========================================
+ Hits 11722 11876 +154
+ Misses 343 193 -150 ☔ View full report in Codecov by Sentry. |
mspelman07
requested changes
Jan 8, 2024
| precip_cube = set_up_variable_cube( | ||
| data, | ||
| name="lwe_thickness_of_precipitation_amount", | ||
| units="m/s", |
There was a problem hiding this comment.
The units for precip accumulation would typically be "m". This would also need an update in the tests.
* master: Bump actions/stale from 8 to 9 (metoppv#1972) Bump codecov/codecov-action from 3 to 4 (metoppv#1942) Bump actions/cache from 3 to 4 (metoppv#1977) Adds CLI to copy attributes from one NetCDF file to another. (metoppv#1976)
* master: Revert "Bump codecov/codecov-action from 3 to 4" (metoppv#1978)
mspelman07
previously approved these changes
Jan 22, 2024
brhooper
requested changes
Jan 22, 2024
Oh dear. I must have been falling asleep to miss this. Acceptance Test PR added: metoppv/improver_test_data#42 |
mspelman07
approved these changes
Jan 23, 2024
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…parts (metoppv#1975) * SnowSplitter output cube names are now the same as their StaGE couterparts. * Corrects failing test by inserting new fixture name. * Updates doc-strings * Sphinx error fix * Flake8 error fix caused by Sphinx error fix * Corrects units of accumulation data in snow splitter test * Updates checksums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://metoffice.atlassian.net/browse/EPPT-650
While testing the EPP Precipitation Type workflows, I have found that the output cube names for rain/snow rate/accum data are not the same as the same data found on StaGE. For accumulation data, the rain and snow outputs had the names of the precipitation cube. This PR modifies the new cube name generation, which is generated from a precipitation cube name, so that:
Testing: