Categorical plugin accepts deterministic conditions #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 98.40% 98.39% -0.01%
==========================================
Files 124 124
Lines 12028 12055 +27
==========================================
+ Hits 11836 11862 +26
- Misses 192 193 +1 ☔ View full report in Codecov by Sentry. |
MoseleyS
requested changes
Nov 14, 2023
improver_tests/categorical/decision_tree/test_ApplyDecisionTree.py
Outdated
Show resolved
Hide resolved
|
I think I should have reassigned this to Marcus last week. |
2e4dda5 to
feb4d66
Compare
MoseleyS
requested changes
Nov 22, 2023
doc/source/extended_documentation/categorical/build_a_decision_tree.rst
Outdated
Show resolved
Hide resolved
MoseleyS
approved these changes
Nov 23, 2023
brhooper
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks @mspelman07. This looks fine - tests show that behaviour is unchanged for existing, probabilistic decision trees, and the new functionality for deterministic decision trees appears to work as intended.
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Make check decision tree work with deterministic nodes * Adds in tests and changes to make ApplyDecisionTree work with deterministic inputs * Formatting * Update documentation to include deterministic nodes * Review response and add test for missing input for deterministic forecasts * Update handling of strings and review response * formatting --------- Co-authored-by: Marcus Spelman <marcus.spelman@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some further changes to the wx symbols plugin so it can work with a decision tree using deterministic inputs. This PR builds on PR #1944 which refactored the code to work with any decision tree. This branch points at master but can't be merged before the previous PR.
I have attempted to write this code so that it doesn't require any changes to the current weather symbols decision tree. This is partially to limit the number of changes that need to be made but also so I can show that the changes I've made don't effect the existing decision tree.
Testing: