Changes to the modal code to increase the percentage to 30% and alter some of the groupings to give a better daily summary symbol. #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the groupings to provide a more representative daily summary symbol.
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
+ Coverage 98.35% 98.36% +0.01%
==========================================
Files 121 122 +1
Lines 11523 11642 +119
==========================================
+ Hits 11333 11452 +119
Misses 190 190
|
MoseleyS
requested changes
Jul 12, 2023
MoseleyS
approved these changes
Jul 12, 2023
bayliffe
approved these changes
Jul 13, 2023
bayliffe
added a commit
to bayliffe/improver
that referenced
this pull request
Jul 28, 2023
* upstream/master: Fix to the wind vertical displacement adjustment implementation (metoppv#1927) Add function which normalises input cubes according to a reference (metoppv#1919) Skip ECC bounds usage when converting probabilities to percentiles (metoppv#1926) Add CLIs to support rescaling of the forecast based on altitude difference (metoppv#1 8000 917) Changes to the modal code to increase the percentage to 30% and change the groupings to provide a more representative daily summary symbol. (metoppv#1925) Add plugins to support rescaling of the forecast based on altitude difference (metoppv#1916) Support conversion from percentiles to probabilities (metoppv#1924) Correct handling of reference time in weather_code plugin (metoppv#1920) Add CLI for clipping cubes (metoppv#1918) Update cbh ecc name (metoppv#1922) Updates Broadcast and expand_bounds in Combine Plugin (metoppv#1914) Mobt515 cloud base height spot extraction (metoppv#1911) MOBT-494: Cube title setting in weather symbol code (metoppv#1912) MOBT512-masking percentiles for cloud base height (metoppv#1908) Mobt 496 enforce forecast between references (metoppv#1907)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…e the groupings to provide a more representative daily summary symbol. (metoppv#1925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating the various options for improving the daily summary symbol we decided that the best option in the time allowed was:
Change the minimum modal percentage from 10% to 30% to allow the code to use the grouping in more situations.
Change the groupings to make them more representative. This involved adding drizzle to the "rain" grouping and also adding a "visibility" grouping containing mist and fog. The new groupings can be seen below:
"snow": [23, 24, 26, 27] (light snow shower, light snow, heavy snow shower, heavy snow)
"sleet": [17, 18] (sleet shower, sleet)
"rain": [10, 11, 12, 14, 15] (light shower, drizzle, light rain, heavy shower, heavy rain)
"convection": [20, 21, 29, 30] (hail shower, hail, thunder shower, thunder)
"visibility": [5, 6] (mist, fog)
This ticket makes those changes.
Acceptance test data: metoppv/improver_test_data#22
Testing: