enable tortoise to move to Working from BackToNormal when there is no HPA #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchavey
reviewed
May 20, 2025
| @@ -135,6 +135,13 @@ func (s *Service) UpdateTortoisePhase(tortoise *v1beta3.Tortoise, now time.Time) | |||
| s.recorder.Event(tortoise, corev1.EventTypeNormal, event.Working, "Emergency mode is turned off. Tortoise starts to work on autoscaling normally. HPA.Spec.MinReplica will gradually be reduced") | |||
| tortoise.Status.TortoisePhase = v1beta3.TortoisePhaseBackToNormal | |||
| } | |||
| case v1beta3.TortoisePhaseBackToNormal: | |||
| if !hasHorizontal(tortoise) { | |||
| // If there's no HPA, we can transition directly to Working | |||
There was a problem hiding this comment.
nit: comment not needed, we have the info in the event below.
There was a problem hiding this comment.
the 2 comments cover 2 cases of
- if HPA not present
- if HPA present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #444
What:
BackToNormaltoWorkingso that new recommendations can be appliedWhy:
BackToNormalphase i.e after switching fromEmergencyMode would continue to stay inBacktoNormaldue to the fact that the existing logic at line would execute only when there is a corresponding HPA which is evident from this line.