8000 feat: add light_klx from bresser 7 in 1 by acesyde · Pull Request #2061 · merbanan/rtl_433 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add light_klx from bresser 7 in 1 #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2022
Merged

feat: add light_klx from bresser 7 in 1 #2061

merged 4 commits into from
Apr 28, 2022

Conversation

acesyde
Copy link
Contributor
@acesyde acesyde commented Apr 28, 2022

Add missing light_klx

Logs :

INFO:root:Published Bresser-7in1/47539: time, temperature_C, humidity, wind_max_m_s, wind_avg_m_s, wind_dir_deg, rain_mm, uv, battery_ok
INFO:root:Skipped Bresser-7in1/47539: light_klx

@zuckschwerdt
Copy link
Collaborator

Oh, that slipped through on review and should always have been light_lux, we need to change that in Bresser-7in1. (and having "lux" as unit name everywhere is also unfortunate, the SI unit is "lx".)

Please change the PR to fix the key and scaling, then we'd need to let it sit a week or so with "Breaking change" warning to allow users a chance the comment.

@acesyde
Copy link
Contributor Author
acesyde commented Apr 28, 2022

Hi @zuckschwerdt

Like that ?

@zuckschwerdt
Copy link
Collaborator

Looks good. Also comment all klx lines with // TODO: remove this

@acesyde
Copy link
Contributor Author
acesyde commented Apr 28, 2022

@zuckschwerdt done ;)

@zuckschwerdt zuckschwerdt merged commit 9eec461 into merbanan:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acesyde @zuckschwerdt
0