-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Handle StateDB .extract()
properly
#6293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle StateDB .extract()
properly
#6293
Conversation
Fix the StateDB properly for stateDiagram-v1 vs stateDiagram-v2.
🦋 Changeset detectedLatest commit: cfd84e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6293 +/- ##
==========================================
- Coverage 4.47% 4.46% -0.01%
==========================================
Files 385 385
Lines 54244 54262 +18
Branches 598 598
==========================================
Hits 2425 2425
- Misses 51819 51837 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (although I don't know if I can approve it since I was the author of cfe710f)
@@ -136,7 +136,6 @@ const renderDoc = (doc, diagram, parentId, altBkg, root, domDocument, diagObj) = | |||
return {}; | |||
}); | |||
|
|||
diagObj.db.extract(doc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I was planning to remove this duplicate extraction in the TS conversion.
Fix the StateDB properly for stateDiagram-v1 vs stateDiagram-v2.
📑 Summary
StateDB
constructor.setRootDoc
method to handle multiple versions.StateDB
.extract
calls.📏 Design Decisions
N/a
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.