8000 Add Xpeng G6 Profile by stevelea · Pull Request #394 · meatpiHQ/wican-fw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Xpeng G6 Profile #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

Add Xpeng G6 Profile #394

merged 3 commits into from
May 6, 2025

Conversation

stevelea
Copy link
Contributor

Add Xpeng G6 SOC, working on adding other PID's

@stevelea
Add files via upload
< 8000 /batch-deferred-content>
0c2dd67 
Add Xpeng G6 SOC
@stevelea stevelea requested a review from meatpiHQ as a code owner April 30, 2025 12:29
@meatpiHQ
Copy link
Owner
meatpiHQ commented May 4, 2025

@stevelea Thank you! The profile file should look like this:

{
  "car_model": "XPeng: G6",
  "init": "ATSP6;ATFCSH704;ATFCSD300000;ATFCSM1;",
  "pids": [
    {
      "pid": "22031E",
      "pid_init": "ATSH7E0;",
      "parameters": {
        "SOC": "[B4:B5]/10",
      }
    }
  ]
}

@stevelea
Update xpeng_g6.json
a1bd325 
Thanks, i have updated as suggested however i think there maybe a bug in the web code. When i load from a file in the wican web interface i dont get SOC appearing. I tested by loading the zeekr file from a local file ( copied from repo ) and the same no SOC. But if i do get latest and load the zeekr profile from repo it works.
@stevelea
Copy link
Contributor Author
stevelea commented May 5, 2025

Thanks, i have updated as suggested however i think there maybe a bug in the web code. When i load from a file in the wican web interface i dont get SOC appearing. I tested by loading the zeekr file from a local file ( copied from repo ) and the same no SOC. But if i do get latest and load the zeekr profile from repo it works.

meatpiHQ
meatpiHQ requested changes May 5, 2025
View reviewed changes
Copy link
Owner
@meatpiHQ meatpiHQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the SoC to [B4:B5]/10. It's basically the same thing but this is cleaner.

Yes you are right the upload file is broken, it's still following the old schema.

@stevelea
Update xpeng_g6.json
b35c675 
Changes to calc as requested
@stevelea
Copy link
Contributor Author
stevelea commented May 6, 2025

Done

@meatpiHQ meatpiHQ merged commit 5170c08 into meatpiHQ:main May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatpiHQ meatpiHQ meatpiHQ requested changes

Assignees
4B03 No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevelea @meatpiHQ
0