[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sidebars): format #36999

Merged
merged 2 commits into from
Nov 27, 2024
Merged

chore(sidebars): format #36999

merged 2 commits into from
Nov 27, 2024

Conversation

fiji-flo
Copy link
Contributor
@fiji-flo fiji-flo commented Nov 27, 2024

Description

ran rari content fmt-sidebars and rari content sync-sidebars

Motivation

To support automated updates on content move we need to serialize the sidebars. To do that we should keep them in a standard format and not allow comments.

We also make the /en-US/docs for the path property in listSubPages and listSubPagesGrouped implicit.

ran `rari content fmt-sidebars`
@fiji-flo fiji-flo requested a review from a team as a code owner November 27, 2024 11:53
@github-actions github-actions bot added the size/xl [PR only] >1000 LoC changed label Nov 27, 2024
We don't need the /en-US/docs prefix for the path in
`listSubPages` and `listSubPagesGrouped`. It's now implicit.
Copy link
Member
@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@fiji-flo fiji-flo merged commit 4b5a4f1 into main Nov 27, 2024
7 checks passed
@fiji-flo fiji-flo deleted the fmt-new-sidebars branch November 27, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants