8000 Add multi-monitor support by allowing the user to specify which monitor findex should open on by Longestboi · Pull Request #69 · mdgaziur/findex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ findex Public

Add multi-monitor support by allowing the user to specify which monitor findex should open on #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you 8000 account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add multi-monitor support by allowing the user to specify which monitor findex should open on #69

merged 1 commit into from
Nov 21, 2024

Conversation

Longestboi
Copy link
Contributor

When using a multi-monitor setup, findex would not open on the primary monitor if another monitor was positioned directly above it.

I believe the changes to the window.move_() arguments in GUI::position_window alone would fix this but I'm sure others may want findex to open on a monitor other than their primary one, so I added a config setting to allow the user to specify which monitor findex should open on.

I haven't tested this in Wayland, so that will need to be tested.

@mdgaziur
Copy lin A2AB k
Owner

LGTM! Thanks for your kind contribution :^)

@mdgaziur
Copy link
Owner

I guess I will test this on Wayland when I get the chance to do it myself. In the meantime, I'll add a warning.

@mdgaziur mdgaziur merged commit 3eb64df into mdgaziur:development Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdgaziur mdgaziur mdgaziur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Longestboi @mdgaziur
0