fix: Discard track change alerts at core CR stops #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
approved these changes
Apr 29, 2025
Comment on lines
855
to
856
| private fun List<Alert>.discardTrackChangesAtCRCore(isCRCore: Boolean): List<Alert> = | ||
| if (isCRCore) this.filterNot { it.effect == Alert.Effect.TrackChange } else this |
There was a problem hiding this comment.
suggestion (non-blocking): This could be moved to the Alert file for consistency with how we've co-located list extension functions for UpcomingTrip in that file.
There was a problem hiding this comment.
I couldn't decide if it made sense for it to be public outside of this, since it's pretty specific to this use case, but I yeah I'll move it out just for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Group by Direction | Discard track changes at core stations
We had a check in the
NearbyStaticDatato remove track change alerts from core CR stops (South and North St, Ruggles, Back Bay), which hadn't been included in theRouteCardDatalogic. This adds it.iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Added new unit test verifying this behavior, manually verified with test alerts on dev orange