feat(RouteCardData): Disruption on branch cases #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Apr 25, 2025
Comment on lines
-123
to
+125
| override val hasSchedulesToday: Boolean, | ||
| val hasSchedulesTodayByPattern: Map<String, Boolean>, |
There was a problem hiding this comment.
This is one of my least favorite changes in this PR, but it seemed like the most straightforward path to determining whether we should show "Predictions Unavailable" for a branch with no service vs. if we are dealing with a no scheduled service / service ended scenario.
Merged
4 tasks
…so it will be easier to reuse pieces in the stop details page
8f8dd0f to
a6af465
Compare
BrandonTR
approved these changes
Apr 25, 2025
| @@ -863,7 +1033,7 @@ data class RouteCardData( | |||
| this.upcomingTrips ?: emptyList(), | |||
| checkNotNull(alertsHere), | |||
| allDataLoaded ?: false, | |||
| hasSchedulesToday ?: false, | |||
| hasSchedulesTodayByPattern ?: routePatterns!!.associate { it.id to false }, | |||
There was a problem hiding this comment.
Nitpick: We could also checkNotNull(routePatterns) here for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Group By Direction | Disruption on a branch
What is this PR for?
With this PR, we now show a separate row for disrupted branches when grouped by headsign to match designs.
Grouping by headsign when we know we are dealing with a branched route seemed like the most straightforward way to accomplish this. TY to @EmmaSimon for feedback on where that grouping logic should live!
iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?
Updated stubbed out unit tests
Updated android preview data & confirmed displayed as expected
Tested in running app for a few alerts
