feat(Android): Add empty favorites tab #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a non-ideal transition in the map between nearby and favorites.
boringcactus
approved these changes
May 13, 2025
androidApp/src/main/java/com/mbta/tid/mbta_app/android/SheetRoutes.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Favorites | Add empty favorites tab
Add a new tab behind the favorites feature flag on Android. I managed to get the map not to reload by keeping the initial sheet entrypoint as a separate piece of state within
ContentView, which is then passed down intoMapAndSheetPageand used as the initial route in the sheet'sNavHost.iOS
android
- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Updated existing tests to pass