chore: remove group by direction feature flag #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # androidApp/src/androidTest/java/com/mbta/tid/mbta_app/android/stopDetails/StopDetailsFilteredDeparturesViewTest.kt
boringcactus
approved these changes
May 6, 2025
iosApp/iosApp.xctestplan
Outdated
| @@ -50,7 +50,6 @@ | |||
| { | |||
| "parallelizable" : true, | |||
| "skippedTests" : [ | |||
| "EndToEndOpenStopDetailsTest\/testOpenStopDetails()", | |||
There was a problem hiding this comment.
This change should also be made in iosAppRetries.xctestplan.
|
Showing tests passing locally for posterity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Group by direction | Remove feature flag
Removes the group by direction feature flag, this includes Melody's
StopDetailsViewTestmodifications to reduce merge conflicts!Testing
Removed and tweaked tests that relied on feature flag.