feat(iOS): Nearby transit direction grouping UX #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of this was removing an unnecessary NearbyTransitState binding
4 tasks
11fafb1 to
37af9f7
Compare
3f58363 to
b15e28e
Compare
Also remove a test that was only failing in CI, with a more basic replacement testShowsBranchingHeadsigns in RouteCardDeparturesTests.
KaylaBrady
approved these changes
Apr 22, 2025
| @@ -42,7 +42,8 @@ sealed class LeafFormat { | |||
| */ | |||
| val route: Route?, | |||
| val headsign: String, | |||
| val format: UpcomingFormat | |||
| val format: UpcomingFormat, | |||
| val id: String = "$headsign-$format" | |||
There was a problem hiding this comment.
question (non-blocking): Is this required to be unique? I think it might not be in rare cases like bus bunching, where you could have two buses with the same headsign both arriving "Now"
There was a problem hiding this comment.
Ah, hmm, good point. This was really just to make the ForEach happy, so it would just give one of those "the ID X occurs multiple times within the collection, this will give undefined results" errors, which isn't ideal but generally doesn't seem to cause major problems. Maybe I could tack on a UUID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Group by direction | Barebones Nearby Transit UX
Group by direction in nearby.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Testing
NearbyTransitViewLegacyTestsNearbyTransitViewTestsreplaces each of the legacy tests with new ones that use direction grouping, except fortestLineGrouping, which was failing only in CI for unclear reasons, it was replaced withRouteCardDeparturesTests.testShowsBranchingHeadsignsRouteCardTests,RouteCardStopHeaderTests, andRouteCardDeparturesTests.