fix: trip display on disrupted branches #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
approved these changes
Apr 14, 2025
| trip.headsign, | ||
| UpcomingFormat.Some( | ||
| format, | ||
| UpcomingFormat.SecondaryAlert(StopAlertState.Issue, mapStopRoute) |
There was a problem hiding this comment.
suggestion (non-blocking): I think we don't need to include the alert here after all, based on this alert case.
There was a problem hiding this comment.
Would we want to just pass in null? I assume that would leave us without any indication of a disruption in the interim
There was a problem hiding this comment.
Yeah I think null would be OK, but also totally fine to leave as-is for the interim state since this will be refined in the upcoming disruption on a branch task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Group by direction | Add in alerts data
This attempts to solve for this case in figma.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Filled in a unit test that tests this scenario.