8000 feat: display status alongside time for commuter rail in filtered stop details by boringcactus · Pull Request #724 · mbta/mobile_app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: display status alongside time for commuter rail in filtered stop details #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

boringcactus
Copy link
Member
@boringcactus boringcactus commented Feb 7, 2025

Summary

Ticket: CR information | Represent CR status that can co-exist with prediction

Matches the Figma design.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • [ ] Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

Checked that the styles are correctly displayed alongside the prediction in filtered stop details only.

@boringcactus boringcactus requested a review from a team as a code owner February 7, 2025 22:50
@boringcactus boringcactus changed the title feat: add TimeWithStatus display state for commuter rail feat: display status alongside time for commuter rail in filtered stop details Feb 11, 2025
@boringcactus boringcactus merged commit 5fcfb8d into main Feb 12, 2025
6 checks passed
@boringcactus boringcactus deleted the mth-timewithstatus branch February 12, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0