8000 feat(Android): Vehicle taps display trip details by EmmaSimon · Pull Request #775 · mbta/mobile_app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(Android): Vehicle taps display trip details #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

EmmaSimon
Copy link
Contributor

Summary

Ticket: 🤖 | Tapping on vehicle updates trip details

Make vehicles on the map tappable on Android to display trip details for their current trips, and lock to selected vehicles even after they pass the target stop.

android
- [ ] All user-facing strings added to strings resource in alphabetical order
- [ ] Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

Manual testing of vehicle selection, we still don't have a good way to write unit tests for map behavior.

@EmmaSimon EmmaSimon requested a review from a team as a code owner February 21, 2025 17:39
@EmmaSimon EmmaSimon merged commit ddc67e7 into main Feb 21, 2025
4 checks passed
@EmmaSimon EmmaSimon deleted the es-android-vehicle-taps branch February 21, 2025 19:34
Reviewers

@boringcactus boringcactus boringcactus approved these changes

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0