Fix/gh 48 export relative paths #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whombat stores paths relative to the root audio_dir, so we need to first fix this, and the the `to_aoef` function removes the prefix of the dataset audio dir.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 66.60% 66.61% +0.01%
==========================================
Files 179 179
Lines 8372 8375 +3
==========================================
+ Hits 5576 5579 +3
Misses 2796 2796 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue reported by @namitha-sh (#48) where exported recording paths were not correctly relative to the dataset's audio directory.
While a previous attempt to address this (PR #49) introduced a test to verify relative paths, the test itself contained a flaw. This PR corrects the test implementation and applies the necessary fix to the
exportmethod of the dataset API to ensure all exported recording paths are now correctly relative to the dataset's audio directory.