Fix: Use PATCH method for onboarding preferences form #2399
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The form on the user onboarding preferences page was submitting with the POST HTTP method, which caused an ActionController::RoutingError because the /users/:id route only accepts PATCH/PUT for updates. This appeared to be a state-related bug where form_with was not correctly inferring the method from the persisted @user object during the initial onboarding flow. This change explicitly sets `method: :patch` on the form_with helper to ensure the correct verb is always used, resolving the routing error for all new users. Fixes maybe-finance#2398
zachgoll
reviewed
Jun 20, 2025
| @@ -63,7 +63,7 @@ | |||
|
|
|||
| <p class="text-secondary text-xs mb-4"><%= t(".preview") %></p> | |||
|
|
|||
| <%= styled_form_with model: @user, data: { turbo: false } do |form| %> | |||
| <%= styled_form_with model: @user, method: :patch, data: { turbo: false } do |form| %> | |||
There was a problem hiding this comment.
If I'm not mistaken, Rails should already be submitting a PUT request since the @user exists already and is not a new record. I'm not actually able to reproduce the original error either, so I'm wondering if there is an unrelated bug going on instead?
There was a problem hiding this comment.
Might be, I didn't went back and rebuild the DB and the data after I found such issue I quickly drafted a solution and continued the onboarding process, when I posted this bug report I also thought it was some kind of one time issue and it was weird for me as well, good that you were not able to reproduce it though.
Zach, check your mail when you can please I sent you a mail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form on the user onboarding preferences page was submitting with the POST HTTP method, which caused an ActionController::RoutingError because the /users/:id route only accepts PATCH/PUT for updates.
This appeared to be a state-related bug where form_with was not correctly inferring the method from the persisted @user object during the initial onboarding flow.
This change explicitly sets
method: :patchon the form_with helper to ensure the correct verb is always used, resolving the routing error for all new users.Fixes #2398