8000 Default timestamp (without time zone) to UTC & Remove select DB time zone by MichaelS11 · Pull Request #370 · mattn/go-oci8 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default timestamp (without time zone) to UTC & Remove select DB time zone #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Default timestamp (without time zone) to UTC & Remove select DB time zone #370

merged 1 commit into from
Nov 29, 2019

Conversation

MichaelS11
Copy link
Contributor

Inserting a timestamp (without time zone) just truncates the time zone from timestamp with time zone. So the previous PR does not work.

Changed default time zone to UTC.

@mattn Please create version 0.0.2 and delete broken version 0.0.1.

@MichaelS11
Copy link
Contributor Author

@mattn ?

@mattn
Copy link
Owner
mattn commented Nov 29, 2019

LGTM

@mattn mattn merged commit a4c59c0 into mattn:master Nov 29, 2019
@mattn
Copy link
Owner
mattn commented Nov 29, 2019

Thank you

@MichaelS11 MichaelS11 deleted the timestamp branch November 29, 2019 20:05
@MichaelS11
Copy link
Contributor Author

Thank you @mattn
Could you set this to version 0.0.1 ?

@mattn
Copy link
Owner
mattn commented Nov 30, 2019

okay, I'll release v0.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0