8000 commands/plugin_e2_test: fix an error assertion issue by isacikgoz · Pull Request #612 · mattermost/mmctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

commands/plugin_e2_test: fix an error assertion issue #612

Merged
merged 1 commit into from
Nov 18, 2022
Merged

commands/plugin_e2_test: fix an error assertion issue #612

merged 1 commit into from
Nov 18, 2022

Conversation

isacikgoz
Copy link
Member

Summary

I should've update the branches before merging 🤦

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Nov 18, 2022
@isacikgoz isacikgoz requested a review from noxer November 18, 2022 12:54
noxer
noxer approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor
@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. With the dependency upgrade some of the tests had to change as well. Thanks for the PR.

@noxer noxer added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 18, 2022
@isacikgoz isacikgoz merged commit 567af5c into master Nov 18, 2022
@isacikgoz isacikgoz deleted the fix-e2e-test branch November 18, 2022 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noxer noxer noxer approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isacikgoz @noxer
0