8000 feat(forge): Automatically download dylibs defined in `cog.scm` by nik-rev · Pull Request #424 · mattwparas/steel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(forge): Automatically download dylibs defined in cog.scm #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2025
Merged

feat(forge): Automatically download dylibs defined in cog.scm #424

merged 6 commits into from
Jun 23, 2025

Conversation

nik-rev
Copy link
Contributor
@nik-rev nik-rev commented Jun 17, 2025

This PR lets you add a #:urls to any dylib

In which case, we will download the dylib at the specified location

Example:

(define dylibs
  '((#:name "ghost_text"
     #:urls
     (
      (
       #:platform
       "x86_64-windows"
       #:url
       "https://github.com/nik-rev/ghost-text.hx/releases/download/v0.1.2/ghost_text.dll")
      (
       #:platform
       "x86_64-macos"
       #:url
       "https://github.com/nik-rev/ghost-text.hx/releases/download/v0.1.2/libghost_text.dylib")
      (
       #:platform
       "x86_64-linux"
       #:url
       "https://github.com/nik-rev/ghost-text.hx/releases/download/v0.1.2/libghost_text.so")))))

@mattwparas
Copy link
Owner

Eventually I would like to replace this with a steel only solution, but for now we can roll with it. Seems easy enough to swap out when the time comes.

mattwparas
mattwparas reviewed Jun 21, 2025
View reviewed changes
mattwparas
mattwparas reviewed Jun 22, 2025
View reviewed changes
@mattwparas
Copy link
Owner

Just the one comment, and otherwise can you run a rust fmt on that file? The build should pass then

@nik-rev nik-rev requested a review from mattwparas June 22, 2025 04:46
@mattwparas mattwparas merged commit b41d5f6 into mattwparas:master Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwparas mattwparas mattwparas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nik-rev @mattwparas
0