8000 Replace OnSceneWasLoaded with sceneLoaded delegate by rhysp · Pull Request #4 · mattvr/syrinj · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace OnSceneWasLoaded with sceneLoaded delegate #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace OnSceneWasLoaded with sceneLoaded delegate #4

wants to merge 1 commit into from

Conversation

rhysp
Copy link
@rhysp rhysp commented Sep 5, 2016 •
edited
Loading

Issue #3
Unfortunately I'm unsure how to open the standalone Scene.unity file (to recompile Syrinj.unitypackage and also ensure tests are still passing. Happy to review with any insight.

@rhysp rhysp changed the title #3: Replace OnSceneWasLoaded with sceneLoaded delegate Replace OnSceneWasLoaded with sceneLoaded delegate Sep 5, 2016
mattvr
mattvr requested changes Feb 4, 2018
View reviewed changes
Copy link
Owner
@mattvr mattvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SceneManager.sceneLoaded should be unsubscribed from when the script is destroyed (ie OnDestroy()).

This will also require you using a named method instead of an anonymous method.

@mattvr
Copy link
Owner
mattvr commented Feb 4, 2018

Thanks for the contribution @rhysp! I've stopped working on it myself but will approve pull requests if they're tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattvr mattvr mattvr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysp @mattvr
0