8000 Synchrotrons and federation sender broken on latest develop · Issue #2655 · matrix-org/synapse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Synchrotrons and federation sender broken on latest develop #2655

Closed
turt2live opened this issue Nov 9, 2017 · 3 comments
Closed

Synchrotrons and federation sender broken on latest develop #2655

turt2live opened this issue Nov 9, 2017 · 3 comments

Comments

@turt2live
Copy link
Member

Description

They spit out errors like:

synchrotron_1 - 2017-11-09 05:47:09,028 - synapse.http.server - 139 - ERROR - GET-908- Failed handle request synapse.http.server._async_render on <synapse.http.server.JsonResource object at 0x7ff0b7509810>: <XForwardedForRequest at 0x7ff0b446b710 method=GET uri=/_matrix/client/r0/sync?filter=120&full_state=false&timeout=10000&since=paginationTokenHere&access_token=<redacted> clientproto=HTTP/1.0 site=8050>
Traceback (most recent call last):
  File "/root/synapse/local/lib/python2.7/site-packages/synapse/http/server.py", line 116, in wrapped_request_handler
    yield request_handler(self, request, request_metrics)
AttributeError: 'SynchrotronSlavedStore' object has no attribute '_state_group_cache'
synchrotron_1 - 2017-11-09 05:47:09,029 - synapse.access.http.8050 - 91 - INFO - GET-908- 138.197.141.99 - 8050 - {@voyager:t2bot.io} Processed request: 85ms (27ms, 4ms) (163ms/89) 55B 500 "GET /_matrix/client/r0/sync?filter=120&full_state=false&timeout=10000&since=paginationTokenHere&access_token=<redacted> HTTP/1.0" "None"

federation_sender - 2017-11-09 05:49:53,937 - synapse.replication.tcp.client - 106 - INFO - - Received rdata events -> 43860735
federation_sender - 2017-11-09 05:49:53,941 - twisted - 131 - CRITICAL - - Unhandled error in Deferred:
federation_sender - 2017-11-09 05:49:53,942 - twisted - 131 - CRITICAL - -
Traceback (most recent call last):
  File "/root/synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1386, in _inlineCallbacks
    result = g.send(result)
  File "/root/synapse/local/lib/python2.7/site-packages/synapse/storage/state.py", line 714, in _get_state_for_groups
    group
  File "/root/synapse/local/lib/python2.7/site-packages/synapse/storage/state.py", line 687, in _get_all_state_from_cache
    is_all, _, state_dict_ids = self._state_group_cache.get(group)
AttributeError: 'FederationSenderSlaveStore' object has no attribute '_state_group_cache'

Version information

  • Homeserver: t2bot.io
  • Version: 0.24.1 (develop)
  • Install method: pip
  • Platform: container
@turt2live
Copy link
Member Author

Because it was an issue last time, here's the nginx config I have for the synchrotron:

location /_matrix/client/r0/sync {
    include /etc/nginx/mx_proxy_settings.conf;
    proxy_pass http://synchrotron;
}

(I only use the /sync endpoint, so the others don't get proxied).

mx_proxy_settings is just

proxy_read_timeout 600s;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $remote_addr;

@turt2live
Copy link
Member Author

This appears to have been broken by f5cf363 which was #2649

@richvdh richvdh mentioned this issue Nov 9, 2017
Merged
richvdh added a commit that referenced this issue Nov 9, 2017
@richvdh
Pull out bits of StateStore to a mixin
2f4f424 
... so that we don't need to secretly gut-wrench it for use in the slaved
stores. I haven't done the other stores yet, but we should. I'm tired of the
workers breaking every time we tweak the stores because I forgot to gut-wrench
the right method.

fixes #2655.
richvdh added a commit that referenced this issue Nov 14, 2017
@richvdh
Pull out bits of StateStore to a mixin
35a4b63 
... so that we don't need to secretly gut-wrench it for use in the slaved
stores. I haven't done the other stores yet, but we should. I'm tired of the
workers breaking every time we tweak the stores because I forgot to gut-wrench
the right method.

fixes #2655.
@richvdh
Copy link
Member
richvdh commented Nov 14, 2017

This got fixed by ab335ed.

@richvdh richvdh closed this as completed Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2EB1
2 participants
@turt2live @richvdh
0