-
Notifications
You must be signed in to change notification settings - Fork 370
Render a button for other linux sources for ecosystem/clients #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk, should this be a a triangle or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thibaultamartin do we have a guideline/source how to create these?
This wasn't an oversight but a deliberate decision to only either list flathub, since it's the go-to platform to distribute Linux apps on all distros, or to link to the website of the project where developers can expand on the additional options they have to support (native packages, appimages, etc). We can't really have a single button "for Linux" since it can be a rpm, a deb, a link to flathub, an appimage, etc. Are you happy to close this PR, or do you want to discuss it further? |
This was prompted by #2677 (and #2690), you can see how that would be confusing. I think it's unfortunate to have the download button "hidden" behind "Repository" for some projects https://matrix.org/ecosystem/clients/ement/ (where is my PR deployment?). We could have an explicit "other" (actual label tbd) download button that is supposed to the project's releases page, homepage, etc? If this were properly decided, perhaps we should remove the links from this field in the data then in favor of a boolean flag? We should also explain this in appropriate places Line 146 in f4ff7fe
|
I like the idea of a "Releases" link that leads to a web page where the maintainer can list options themselves 👍 |
How do you imagine this to look like? I think it should still be part of the download buttons, because that is consistent with the UX of "where do I get this thing". |
Seems to have been an oversight?
Signed-off-by: HarHarLinks 2803622+HarHarLinks@users.noreply.github.com