8000 dev: fix: rm folders with sudo privileges by marcello33 · Pull Request #170 · maticnetwork/matic-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dev: fix: rm folders with sudo privileges #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2023
Merged

dev: fix: rm folders with sudo privileges #170

merged 2 commits into from
Mar 21, 2023

Conversation

marcello33
Copy link
Contributor

Description

This PR fixes behaviour of rm -rf by running it with sudo privileges.
Also, it updates the snapshots URLs of bor and heimdall

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 requested a review from a team March 20, 2023 17:01
pratikspatil024
pratikspatil024 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member
@pratikspatil024 pratikspatil024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious to know, where are we using the newly added env variables like SHADOW_CHAIN_ID, HEIMDALL_SEEDS, NETWORK, etc.

@Raneet10
Copy link
Member

Just curious to know, where are we using the newly added env variables like SHADOW_CHAIN_ID, HEIMDALL_SEEDS, NETWORK, etc.

Yeah these are added in #157 for the purpose of setting up mumbai/mainnet nodes.

@Raneet10
Copy link
Member

Actually @marcello33 , will it makes more sense to update the example config changes in #157 ?

@marcello33 marcello33 changed the title dev: fix: rm folders with sudo privileges / update bor and heimdall snapshots dev: fix: rm folders with sudo privileges Mar 21, 2023
@marcello33
Copy link
Contributor Author

Actually @marcello33 , will it makes more sense to update the example config changes in #157 ?

Agreed @Raneet10
Moved such changes to your PR and left this only for the privileges on rm -rf which was failing

@marcello33
Copy link
Contributor Author

Actually @marcello33 , will it makes more sense to update the example config changes in #157 ?

Agreed @Raneet10
Moved such changes to your PR and left this only for the privileges on rm -rf which was failing

Just curious to know, where are we using the newly added env variables like SHADOW_CHAIN_ID, HEIMDALL_SEEDS, NETWORK, etc.

Thanks @pratikspatil024
Moved the changes to the original PR

@marcello33 marcello33 merged commit f26eb86 into master Mar 21, 2023
@marcello33 marcello33 deleted the mardizzone/small-fixes branch March 21, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xsharma 0xsharma 0xsharma approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcello33 @Raneet10 @0xsharma @pratikspatil024
0