8000 deleteCookie() method should set the correct expiry by sgiehl · Pull Request #17 · matomo-org/matomo-php-tracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

deleteCookie() method should set the correct expiry #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2016
Merged

deleteCookie() method should set the correct expiry #17

merged 1 commit into from
Jan 12, 2016

Conversation

sgiehl
Copy link
Member
@sgiehl sgiehl commented Jan 3, 2016

setCookie() accepts the TTL as parameter not a timestamp, so use a negative TTL to remove the cookies.

fixes #9

@sgiehl sgiehl added this to the Current sprint milestone Jan 3, 2016
mattab pushed a commit that referenced this pull request Jan 12, 2016
Merge pull request #17 from piwik/fix_delete_cookies
f026613 
Fixes deleteCookie() method
@mattab mattab merged commit f026613 into master Jan 12, 2016
@mattab mattab deleted the fix_delete_cookies branch January 12, 2016 21:44
@mattab mattab changed the title Fixes deleteCookie() method deleteCookie() method should set the correct expiry Jan 29, 2016
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current time added twice in method deleteCookies()
3 participants
@sgiehl @mattab @innocraft-automation
0