Android: POST graph token at all times & update Titanium SDK #5464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1ga
reviewed
May 18, 2025
tiapp.xml
Outdated
| @@ -59,7 +59,7 @@ | |||
| </activity> | |||
| </application> | |||
| <supports-screens android:anyDensity="true" android:largeScreens="true" android:normalScreens="true" android:smallScreens="true" xlargeScreens="true"/> | |||
| <uses-sdk android:installLocation="preferExternal" android:minSdkVersion="29" android:targetSdkVersion="34"/> | |||
| <uses-sdk android:installLocation="preferExternal" android:minSdkVersion="30" android:targetSdkVersion="35"/> | |||
There was a problem hiding this comment.
careful with target 35. Please check it on a device to see if the edge-to-edge display looks fine. Otherwise: tidev/titanium-sdk#14111 and add the windowOptOutEdgeToEdgeEnforcement part to your theme
There was a problem hiding this comment.
Great catch @m1ga . Should I continue targeting 34 for now?
There was a problem hiding this comment.
I would remove android:targetSdkVersion="" and let the SDK do that for you (34 is the default anyways). Keep the minSDK.
There is already a PR for target 35 with windowOptOutEdgeToEdgeEnforcement so it will look like the current Ti 12.7.0. Hopefully that gets merged soon and then you can update it when you do an update after November
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5462