8000 Use #[\SensitiveParameter] php attribute to hide sensitive parameters from strack traces by sgiehl · Pull Request #23324 · matomo-org/matomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use #[\SensitiveParameter] php attribute to hide sensitive parameter 8000 s from strack traces #23324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

Use #[\SensitiveParameter] php attribute to hide sensitive parameters from strack traces #23324

merged 6 commits into from
May 30, 2025

Conversation

sgiehl
Copy link
Member
@sgiehl sgiehl commented May 27, 2025 •
edited
Loading

Description:

Since PHP 8.2 the #[\SensitiveParameter] attribute can be used to hide sensitive parameters from being included in stack traces.

This PR aims to mark sensitive parameters across the code base.

Note: As PHP 7 does not support such attributes, they need be placed on a single line before the parameter. That way PHP 7 ignores them as comment, while PHP 8.2+ will use them

Review

@sgiehl sgiehl added this to the 5.4.0 milestone May 27, 2025
@snyk-io Snyk.io
Copy link
snyk-io bot commented May 27, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@sgiehl sgiehl force-pushed the dev-19218 branch 2 times, most recently from 24a1d37 to 9d466e3 Compare May 27, 2025 14:54
@sgiehl sgiehl marked this pull request as ready for review May 28, 2025 07:30
@sgiehl sgiehl mentioned this pull request May 28, 2025
Merged
11 tasks
@sgiehl sgiehl requested a review from a team May 28, 2025 14:41
mneudert
mneudert requested changes May 28, 2025
View reviewed changes
Copy link
Member
@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once the sniff has an updated configuration it should also find some additional violations we can flag in the initial batch, e.g. the Login\PasswordResetter and UsersManager\Model.

@sgiehl sgiehl requested a review from mneudert May 30, 2025 10:28
@sgiehl sgiehl merged commit 158e45a into 5.x-dev May 30, 2025
29 checks passed
@sgiehl sgiehl deleted the dev-19218 branch May 30, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @mneudert
0