8000 Improves detection for Firefox Focus by thinkwelltwd · Pull Request #6947 · matomo-org/device-detector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improves detection for Firefox Focus #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2021
Merged

Improves detection for Firefox Focus #6947

merged 2 commits into from
Dec 27, 2021

Conversation

thinkwelltwd
Copy link
Contributor

The following user agents are not from Firefox Focus

  • Be Focused/104 CFNetwork/976 Darwin/18.2.0
  • Focus/1 CFNetwork/1240.0.4 Darwin/20.5.0
  • Focus Matrix/155 CFNetwork/976 Darwin/18.2.0
  • Klara/1 CFNetwork/1128.0.1 Darwin/19.6.0
  • FLCore v3 - Window Focus
  • Focuskeeper/2.0.15.4 CFNetwork/1240.0.4 Darwin/20.5.0

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@thinkwelltwd
Remove question mark to avoid matching other mobile apps
4754e7c 
The following user agents are not from Firefox Focus

* Be Focused/104 CFNetwork/976 Darwin/18.2.0
* Focus/1 CFNetwork/1240.0.4 Darwin/20.5.0
* Focus Matrix/155 CFNetwork/976 Darwin/18.2.0
* Klara/1 CFNetwork/1128.0.1 Darwin/19.6.0
* FLCore v3 - Window Focus
* Focuskeeper/2.0.15.4 CFNetwork/1240.0.4 Darwin/20.5.0
@sanchezzzhak
Copy link
Collaborator

@sanchezzzhak sanchezzzhak mentioned this pull request Dec 23, 2021
Closed
6 tasks
@sanchezzzhak sanchezzzhak changed the title Remove question mark to avoid matching other mobile apps Improves detection for Firefox Focus Dec 27, 2021
@sanchezzzhak sanchezzzhak enabled auto-merge (squash) December 27, 2021 08:41
@sanchezzzhak sanchezzzhak merged commit 228eef9 into matomo-org:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezzzhak sanchezzzhak sanchezzzhak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkwelltwd @sanchezzzhak
0

the useragent
Focus/1 CFNetwork/1240.0.4 Darwin/20.5.0
maybe it's the browser

  • Mozilla/5.0 (iPad; CPU OS 11_2_5 like Mac OS X) AppleWebKit/604.5.6 (KHTML, like Gecko) Focus/1.1.6 Mobile/15D60
  • Mozilla/5.0 (iPhone; CPU iPhone OS 11_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Focus/1.1.1 Mobile/15E216