8000 [Ray] Implement cancel method on Ray task executor by zhongchun · Pull Request #3044 · mars-project/mars · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray] Implement cancel method on Ray task executor #3044

Merged
merged 19 commits into from
May 24, 2022
Merged

[Ray] Implement cancel method on Ray task executor #3044

merged 19 commits into from
May 24, 2022

Conversation

zhongchun
Copy link
Contributor
@zhongchun zhongchun commented May 17, 2022 •
edited
Loading

What do these changes do?

This pr

  • implements the ray task executor cancel method
  • adds subtask_cancel_timeout property for RayExecutionConfig which is from scheduling.subtask_cancel_timeout

And ray task meta, data gc is in another pr #3061.

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@zhongchun zhongchun requested a review from a team as a code owner May 17, 2022 15:07
@zhongchun zhongchun mentioned this pull request May 17, 2022
Open
fyrestone
fyrestone previously approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor
@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongchun zhongchun force-pushed the feat-ray-executor-cancel branch from 16e62b9 to 2aadec2 Compare May 20, 2022 04:28
chaokunyang
chaokunyang previously approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor
@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongchun zhongchun mentioned this pull request May 24, 2022
Merged
2 tasks
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 24, 2022
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label May 24, 2022
chaokunyang
chaokunyang approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor
@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fyrestone
fyrestone approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor
@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi changed the title [Ray] Implement ray task executor cancel [Ray] Implement cancel method on Ray task executor May 24, 2022
@wjsi wjsi merged 6DB6 commit 8639474 into mars-project:master May 24, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request May 28, 2022
@zhongchun
[Ray] Implement cancel method on Ray task executor (mars-project#3044)
04c0f96 
(cherry picked from commit 8639474)
@qinxuye qinxuye mentioned this pull request May 28, 2022
Merged
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Jun 1, 2022
@zhongchun
[Ray] Implement cancel method on Ray task executor (mars-project#3044)
0c6ad3c 
(cherry picked from commit 8639474)
hekaisheng pushed a commit that referenced this pull request Jun 6, 2022
[BACKPORT] [Ray] Implement cancel method on Ray task executor (#3044) (…
080d6b8 
…#3093)
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrestone fyrestone fyrestone approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: ray integration mod: task service type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongchun @fyrestone @chaokunyang @qinxuye @wjsi @hekaisheng
0