8000 Change `StorageHandlerActor` to stateful by hekaisheng · Pull Request #2824 · mars-project/mars · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change StorageHandlerActor to stateful #2824

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Change StorageHandlerActor to stateful #2824

merged 1 commit into from
Mar 15, 2022

Conversation

hekaisheng
Copy link
Contributor
@hekaisheng hekaisheng commented Mar 15, 2022 •
edited
Loading

What do these changes do?

StorageHandlerActor is stateless before, it leads to potential race condition, change to stateful instead.

Related issue number

Fixes #2800

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working to be backported Indicate that the PR need to be backported to stable branch mod: storage labels Mar 15, 2022
@hekaisheng hekaisheng added this to the v0.9.0rc1 milestone Mar 15, 2022
@hekaisheng hekaisheng requested a review from wjsi as a code owner March 15, 2022 08:35
qinxuye
qinxuye approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator
@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member
@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 5344fb5 into mars-project:master Mar 15, 2022
@qinxuye qinxuye deleted the bugfix/elkan-result branch March 15, 2022 11:18
wjsi pushed a commit to wjsi/mars that referenced this pull request Mar 16, 2022
@hekaisheng @wjsi
Change StorageHandlerActor to stateful (mars-project#2824)
65a63c4
@wjsi wjsi mentioned this pull request Mar 16, 2022
Merged
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: storage type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0rc1
Development

Successfully merging this pull request may close these issues.

[BUG] test_k_means.py::test_elkan_results crash
3 participants
@hekaisheng @qinxuye @wjsi
0