Added checks if style is fully loaded before accessing it #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@albertmoravec Can you describe these "certain situations"? Maybe I can reproduce them on iOS. |
Ah, I did not have much time to check myself, but generally you can break a lot of things by changing map style (e.g. between normal and satellite map) and doing other stuff like clicking into the map while it is loading. At least that's how I triggered this on Android. The map tends to break a lot when you put all its features under stress when style is loading, since a lot of places are missing necessary checks and that breaks Flutter a bit more than for native apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing checks which caused crashes in certain situations on Android.
This is probably an issue on iOS as well, but I don't have access to my Mac at the moment. I'll open a separate PR for iOS if I am able to confirm and fix this.